Harden gossip peer conformance checks - #7
Merged
Merged
Conversation
Validate the full gossip request/response contract in addition to the collision challenge: reject duplicate domains and rumors outside the requested set before adopting peer state. Add unit and real-UDP regression coverage and document the expanded boundary. AI collaborator: GPT-5
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Give the request-scoping gossip integration test its own port pair so it cannot race the existing client API probe test when the workspace tests run in parallel.\n\nAI collaborator: GPT-5
Exercise duplicate and unsolicited gossip rejection, short malformed DNS input, and pending challenge eviction at capacity. These tests raise node.rs coverage without excluding reachable code or weakening the coverage gate.\n\nAI collaborator: GPT-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo test --workspace -- --test-threads=1(184 passed)cargo clippy --workspace --all-targets -- -D warningscargo doc --workspace --no-depscargo llvm-cov --workspace --summary-only -- --test-threads=1(98.37% regions, 99.01% lines, 99.52% functions)git diff --checkThe default parallel UDP test run has an existing timing-sensitive
WouldBlockfailure inprobe_via_client_api_socket_returns_ack; the same test and the complete suite pass serially.